adoroszlai commented on code in PR #7919: URL: https://github.com/apache/ozone/pull/7919#discussion_r1958758682
########## hadoop-hdds/dev-support/checkstyle/suppressions-skip-imports.xml: ########## Review Comment: This file must be removed only when there are no modules referencing it. This applies not only to merging the PR that removes the file, but even starting pre-commit CI. That's because PR run uses a "merge commit": PR changes on top of the base branch as of the time when the PRs last commit was pushed. Therefore, the PR must be created, or updated from `master`, after changes for all other modules have been merged. I would prefer to remove this file in a separate PR to avoid that delay. Keeping the unused file around for a few hours/days is not a problem. I hope such a PR would skip most checks anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
