smengcl commented on code in PR #7848: URL: https://github.com/apache/ozone/pull/7848#discussion_r1956968900
########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OmConfig.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om; + +import org.apache.hadoop.hdds.conf.Config; +import org.apache.hadoop.hdds.conf.ConfigGroup; +import org.apache.hadoop.hdds.conf.ConfigTag; +import org.apache.hadoop.hdds.conf.PostConstruct; + +/** + * Ozone Manager configuration. + */ +@ConfigGroup(prefix = "ozone.om") +public class OmConfig { + + @Config( + key = "server.list.max.size", + defaultValue = "1000", + description = "Configuration property to configure the max server side response size for list calls on om.", + tags = { ConfigTag.OM, ConfigTag.OZONE } + ) + private long maxListSize; Review Comment: Thanks for refactoring this. But I've been long complaining about the greppability of the config key names with config objects because of the (stripping of) prefixes. This makes searching for the full config key name string hard. Could we at least have a comment line for each with the full names? Or is there a better (programmatic) solution for this? Thanks. ```suggestion // ozone.om.server.list.max.size @Config( key = "server.list.max.size", defaultValue = "1000", description = "Configuration property to configure the max server side response size for list calls on om.", tags = { ConfigTag.OM, ConfigTag.OZONE } ) private long maxListSize; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
