adoroszlai commented on code in PR #7796:
URL: https://github.com/apache/ozone/pull/7796#discussion_r1950473270
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconControllerModule.java:
##########
@@ -136,6 +138,12 @@ protected void configure() {
}
}
+ @Provides
+ @Singleton
+ public ExecutorService provideReconExecutorService() {
+ return Executors.newFixedThreadPool(5);
Review Comment:
I don't think this should be shared between different tasks, otherwise
unrelated tasks may delay each other. We need a specific pool for each kind of
task, each with 2 or 3 threads, depending on the task's parallelization level.
Or we should be using the existing task thread pool (managed in
`ReconTaskControllerImpl`), which is configurable.
Also, I guess the threads should be daemons, or the executor should be
shutdown somewhere when stopping Recon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
