[
https://issues.apache.org/jira/browse/HDDS-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924782#comment-17924782
]
Ivan Andika commented on HDDS-12213:
------------------------------------
We need to check with the protobuf compatibility after any change using
protolock (https://github.com/nilslice/protolock).
Please see HDDS-10180 reference.
> Review and fix the default proto enum value
> -------------------------------------------
>
> Key: HDDS-12213
> URL: https://issues.apache.org/jira/browse/HDDS-12213
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Ivan Andika
> Assignee: Peter Lee
> Priority: Major
>
> https://protobuf.dev/programming-guides/proto2/#enum-default
> https://protobuf.dev/programming-guides/proto3/#enum-default
> The default enum value protobuf is the first enum, regardless whether the
> field is optional. In proto3 the "unspecified" field with id 0 *must* be
> specified.
> For example in for ReplicationType and ReplicationFactor, the first enums are
> RATIS and ONE respectively, which might cause RATIS/ONE to be created by
> default.
> We need to review these proto enums and see whether we can improve these.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
