jojochuang commented on code in PR #7740:
URL: https://github.com/apache/ozone/pull/7740#discussion_r1929285256
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/BasicOmKeyInfo.java:
##########
@@ -254,7 +255,7 @@ public static BasicOmKeyInfo getFromProtobuf(String
volumeName,
basicKeyInfo.getFactor(),
basicKeyInfo.getEcReplicationConfig()))
.setETag(basicKeyInfo.getETag())
- .setIsFile(!keyName.endsWith("/"))
+ .setIsFile(basicKeyInfo.getIsFile())
Review Comment:
If an old client send a request containing BasicKeyInfo to a new OM, the
isFile field will not be set and a file would always be identified as not a
file.
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1182,6 +1182,7 @@ message BasicKeyInfo {
optional hadoop.hdds.ECReplicationConfig ecReplicationConfig = 7;
optional string eTag = 8;
optional string ownerName = 9;
+ optional bool isFile = 10;
Review Comment:
BasicKeyInfo was added in HDDS-9079 (1.4.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
