adoroszlai commented on PR #7729: URL: https://github.com/apache/ozone/pull/7729#issuecomment-2610032600
Thanks @apotheque for the patch. > I didn’t even know that the ozonefs-hadoop3-client is intended for Spark `ozonefs-hadoop3-client` is intended for anything that uses `hadoop-client-runtime`, one example is Spark. `shadedPattern` is not specific to Spark, but Hadoop. So I don't think Spark should be included in the artifact name. On the other hand, the prefix `io.trino.hadoop.\$internal` is specific to Trino. > I don’t see a reason to add a separate module just to change one shading rule. I think it depends. - If Ozone release is to include the Trino-specific jar, either a separate module or a change in the build process is necessary. Separate module seems to be less intrusive of the two. - If it's enough to let adventurous Ozone users locally build their own jar for Trino, then this PR may be a good solution. Merging this PR still allows working towards a separate module later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
