ChenSammi commented on code in PR #7456:
URL: https://github.com/apache/ozone/pull/7456#discussion_r1916076203
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -471,8 +471,12 @@ public final class OzoneConfigKeys {
public static final int OZONE_CLIENT_BYTES_PER_CHECKSUM_MIN_SIZE = 8 * 1024;
public static final String OZONE_CLIENT_READ_TIMEOUT
- = "ozone.client.read.timeout";
+ = "ozone.client.read.timeout";
public static final String OZONE_CLIENT_READ_TIMEOUT_DEFAULT = "30s";
+ public static final String OZONE_CLIENT_WRITE_TIMEOUT
+ = "ozone.client.write.timeout";
Review Comment:
The thing is short circuit client leverages existing read timeout(which is
also used by GRPC client) and adds this new write timeout. So I think it'd
better to put the two properties close to each other. I would prefer to
introduce generic property instead of specific property for each client type,
for I think too many properties will increase the configuration complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
