Denisoshka opened a new pull request, #7698: URL: https://github.com/apache/ozone/pull/7698
## What changes were proposed in this pull request? HDDS-6931. Support for serialized pre-process validators. @duongkame in the [HDDS-6931](https://issues.apache.org/jira/browse/HDDS-6931) mentioned: "I think pre-process validation should only perform logic on data which is not supposed to change between pre-process and actual execution in validateAndUpdateCache. Otherwise, that validation should be moved to {{validateAndUpdateCache, }}and is done together with the real data change in a proper lock scope to ensure consistency." ## What is the link to the Apache JIRA [HDDS-6931](https://issues.apache.org/jira/browse/HDDS-6931). ## How was this patch tested? Unit tests [passed](https://github.com/Denisoshka/ozone/actions/runs/12768693846). ## Questions: - Should we write a message to `auditLog` if a request fails in `preExecute`, but not in the `validateAndUpdateCache`? - Could we resolve variables `volumeName` and `bucketName` in method `preExecute` instead of method `validateAndUpdateCache` in class [OMKeysRenameRequest](https://github.com/apache/ozone/blob/b024a6bb5185a7865aebe15dd8a7e6fe5b624446/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysRenameRequest.java#L118)? this could be done by putting these variables as Proto request fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
