errose28 commented on code in PR #7490:
URL: https://github.com/apache/ozone/pull/7490#discussion_r1913835035
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1348,7 +1358,6 @@ public void markContainerUnhealthy(Container container,
ScanResult reason)
} finally {
container.writeUnlock();
}
- createContainerMerkleTree(container);
Review Comment:
Yes, when we have an unhealthy container we should build the tree from the
actual data, but this method only builds the tree from the metadata. I'm
renaming it in the next commit to make that clearer. We should not depend on
just the metadata if we suspect corruption. The way this should work is open ->
unhealthy would trigger an on-demand scan of the container, but that code path
is not in place right now. We may want to add that to our branch actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
