swamirishi commented on code in PR #7652:
URL: https://github.com/apache/ozone/pull/7652#discussion_r1909009292


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/RDBParser.java:
##########
@@ -43,11 +43,19 @@ public class RDBParser implements DebugSubcommand {
       description = "Database File Path")
   private String dbPath;
 
+  @CommandLine.Option(names = {"--schema"},

Review Comment:
   Instead of taking a schema, I would rather take an input of codec to decode 
the value of a column family. For instance if I want to read snapshot diff DB, 
the DB doesn't have DB definition since we create new column families on the 
fly based on the snapdiff job. 



##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/RDBParser.java:
##########
@@ -43,11 +43,19 @@ public class RDBParser implements DebugSubcommand {
       description = "Database File Path")
   private String dbPath;
 
+  @CommandLine.Option(names = {"--schema"},

Review Comment:
   We should open a rocksdb in read only mode and decode value based on the 
ValueCodec 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to