dongjoon-hyun opened a new pull request, #2686:
URL: https://github.com/apache/orc/pull/2686

   ### What changes were proposed in this pull request?
   
   This PR aims to remove unused variable assignments (`URL`, `CLONE`, 
`MAKEDIR`, `VOLUME`) from `docker/run-all.sh`.
   
   ### Why are the changes needed?
   
   These variables are leftovers from before the per-OS build logic was 
extracted into `docker/run-one.sh`, which defines and uses its own 
`CLONE`/`MAKEDIR`/`VOLUME`. In `run-all.sh`, they are never referenced; the 
build loop invokes `./run-one.sh $1 $2 $build` with the positional arguments 
directly. `URL` is also removed because it was only referenced by the unused 
`CLONE`. The `GITHUB_USER=$1` and `BRANCH=$2` assignments are kept as 
documentation of the expected arguments.
   
   ### How was this patch tested?
   
   Manual review.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Fable 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to