dongjoon-hyun opened a new pull request, #2659: URL: https://github.com/apache/orc/pull/2659
### What changes were proposed in this pull request? This PR aims to add `-Wno-unused-result` to `WARN_FLAGS` for `Clang` and `GCC`. ### Why are the changes needed? Recent Protobuf versions annotate `ZeroCopyInputStream::Skip()` with the `nodiscard` attribute, which breaks the build with `-Werror`. - https://github.com/apache/orc/actions/runs/27634606548/job/85193614775 ``` /Users/runner/work/orc/orc/c++/src/ColumnReader.cc:466:9: error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result] inputStream_->Skip(static_cast<int>(step)); ^~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ ``` ### How was this patch tested? Verified manually that `ColumnReader.cc` compiles with the new flags. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
