[
https://issues.apache.org/jira/browse/NIFI-5805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683122#comment-16683122
]
ASF GitHub Bot commented on NIFI-5805:
--------------------------------------
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/3160
@markap14 The updates look good to me. I'm +1 on this PR. However, there
are some conflicts with the recent change and I think it's safe for you to
resolve the conflict instead of me doing that. Please address conflicts and
merge it. Thanks!
> Avro Record Writer service creates byte buffer for every Writer created
> -----------------------------------------------------------------------
>
> Key: NIFI-5805
> URL: https://issues.apache.org/jira/browse/NIFI-5805
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.9.0
>
>
> When we use the Avro RecordSet Writer, and do not embed the schema, the
> Writer uses the Avro BinaryEncoder object to serialize the data. This object
> can be initialized, but instead we create a new one for each writer. This
> results in creating a new 64 KB byte[] each time. When we are writing many
> records to a given FlowFile, this is not a big deal. However, when used in
> PublishKafkaRecord or similar processors, where a new writer must be created
> for every Record, this can have a very significant performance impact.
> An improvement would be to have the user configure the maximum number of
> BinaryEncoder objects to pool and then use a simple pooling mechanism to
> reuse these objects.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
