[ 
https://issues.apache.org/jira/browse/NIFI-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662736#comment-16662736
 ] 

ASF GitHub Bot commented on NIFI-5746:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/3109

    NIFI-5746: Use Node Identifier's node address instead of getting from…

    … socket for RECEIVE prov events; make SEND prov events match syntax of 
RECEIVE prov events
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5746

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3109
    
----
commit c5e79da4449db81119ab898f15ab7c2aa64b9c91
Author: Mark Payne <markap14@...>
Date:   2018-10-24T17:45:55Z

    NIFI-5746: Use Node Identifier's node address instead of getting from 
socket for RECEIVE prov events; make SEND prov events match syntax of RECEIVE 
prov events

----


> The SEND and RECEIVE provenance events for load balancing do not have the 
> same transit uri syntax
> -------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-5746
>                 URL: https://issues.apache.org/jira/browse/NIFI-5746
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.8.0
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.9.0
>
>
> The SEND event has a transit uri like nifi:connection:<connection id>
> The RECEIVE event has a transit uri like nifi://<source node 
> address>/loadbalance/<connection id>
> The RECEIVE event is much preferred, as it indicates not only that the 
> transfer was via load balance but also includes the address of the node and 
> the UUID of the connection. The SEND Transit URI should be changed to 
> nifi://<destination node address>/loadbalance/<connection id>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to