[
https://issues.apache.org/jira/browse/NIFI-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648013#comment-16648013
]
ASF GitHub Bot commented on NIFI-5693:
--------------------------------------
GitHub user davemssavage opened a pull request:
https://github.com/apache/nifi/pull/3068
NIFI-5693 add support for multiple attachments in PutEmail via optional
property
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davemssavage/nifi
NIFI-5693-putemail-attachments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3068
----
commit ec92185f4cb416bf47da3317d105e2fb9112c765
Author: David Savage <davemssavage@...>
Date: 2018-10-12T15:17:59Z
add support for multiple attachments in PutEmail via optional property
----
> PutEmail should support multiple attachments
> --------------------------------------------
>
> Key: NIFI-5693
> URL: https://issues.apache.org/jira/browse/NIFI-5693
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.7.1
> Reporter: David Savage
> Priority: Minor
>
> *As a* NiFi User
> *I want* to create multi part emails with many attachments
> *So that* I can interface NiFi flows with legacy email systems
> For this use case I reviewed this comment here [1] unfortunately the legacy
> system requires individual attachments and is out of my control to upgrade so
> the simple MergeFile based approach will not work.
> I can see three potential solutions to this:
> # Update PutEmail to extend BinFiles and use a similar mechanism to
> MergeFiles to collect many files from the flow. Complexity - Hard,
> Flexibility - High
> # Update PutEmail with an optional attribute to unpack files generated by
> MergeFile and add each entry as a new attachment. Complexity - Medium,
> Hackiness - Medium
> # Ignore PutEmail and use a custom script based on Groovy/Jython etc.
> Complexity - Simple, Supportability Low
> I've created a patch for 2 that I'll submit as a merge request soon.
> Interested in feedback and happy to try other approaches if this is something
> that the community is interested in supporting going forwards.
> [1]
> https://mail-archives.apache.org/mod_mbox/nifi-users/201709.mbox/%3CCALJK9a6oSdy5PXaKE0GxY1M3xQqYW8%2B0UUgsQmtbkO1qMK-MQA%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
