[
https://issues.apache.org/jira/browse/NIFI-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597467#comment-16597467
]
ASF GitHub Bot commented on NIFI-4426:
--------------------------------------
GitHub user thenatog opened a pull request:
https://github.com/apache/nifi/pull/2976
NIFI-4426 - Replaced Java7 jBCrypt implementation which was made for …
…Java7 backwards compatibility. It now uses a normal maven import to
provide jBCrypt.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thenatog/nifi NIFI-4426
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2976.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2976
----
commit 42a98b23a6b5703ee3c59a88cd254ed0c26906dc
Author: thenatog <thenatog@...>
Date: 2018-08-29T16:35:21Z
NIFI-4426 - Replaced Java7 jBCrypt implementation which was made for Java7
backwards compatibility. It now uses a normal maven import to provide jBCrypt.
----
> Remove custom jBCrypt implementation because Java 7 is no longer supported
> --------------------------------------------------------------------------
>
> Key: NIFI-4426
> URL: https://issues.apache.org/jira/browse/NIFI-4426
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.4.0
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Priority: Minor
> Labels: security
> Attachments: Screen Shot 2018-08-28 at 6.38.16 PM.png, Screen Shot
> 2018-08-28 at 6.38.31 PM.png
>
>
> The {{jBCrypt}} library is included and slightly modified in order to provide
> Java 7 compatibility because the external module is compiled for Java 8. Now
> that NiFi doesn't support Java 7, this modification can be removed and the
> standalone module can be depended upon via Maven as per normal.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
