[
https://issues.apache.org/jira/browse/NIFI-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538650#comment-16538650
]
ASF GitHub Bot commented on NIFI-5368:
--------------------------------------
GitHub user markobean opened a pull request:
https://github.com/apache/nifi/pull/2873
NIFI-5368 controller services validated prior to enabling; referenced…
… controller services must be enabled for referencing component to be valid
(mock framework)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markobean/nifi NIFI-5368
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2873
----
commit 3a5d94457b9f470a0b620364f11ceb01eeb7a6ee
Author: Mark Bean <mark.o.bean@...>
Date: 2018-07-05T19:35:15Z
NIFI-5368 controller services validated prior to enabling; referenced
controller services must be enabled for referencing component to be valid (mock
framework)
----
> Referenced Controller Services not being validated in Mock Framework
> --------------------------------------------------------------------
>
> Key: NIFI-5368
> URL: https://issues.apache.org/jira/browse/NIFI-5368
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Tools and Build
> Affects Versions: 1.7.0
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Blocker
> Fix For: 1.8.0
>
>
> During the refactoring for NIFI-950, the validation of of referenced
> Controller Services moved from AbstractConfigurableComponent to
> AbstractComponentNode. While this works fine for NiFi's lifecycle, it does
> cause problems with the Mock Framework. Because the Mock Framework does not
> create an AbstractComponentNode, only the AbstractConfigurableComponent, and
> validates that component directly, referenced Controller Services are not
> validated. Additionally, they are not (and never have been) validated when
> enabled.
> We should update the Mock Framework such that when
> {{TestRunner.enableControllerService(ControllerService)}} is called, we first
> validate the Controller Service before enabling it.
> Additionally, in the {{AbstractConfigurableComponent}}, or in the Mock
> Framework itself, verify that all referenced services are in fact enabled
> when validating the component.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
