[
https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537942#comment-16537942
]
ASF GitHub Bot commented on NIFI-5376:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2841#discussion_r201208939
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/flow/TestPopularVoteFlowElection.java
---
@@ -46,6 +45,19 @@
public class TestPopularVoteFlowElection {
+ /**
+ * Utility method which accepts {@link NiFiProperties} object but
calls {@link StringEncryptor#createEncryptor(String, String, String)} with
extracted properties.
--- End diff --
ok yeah this method seems like a good candidate for being in 'nifi-mock' or
some nifi test utils module. This call is needed in a lot of tests. But we
dont want/need additional deps to some module in mainline code as the framework
can pull from nifi props as this is doing and avoid another dependency just to
share across code and tests..
> Remove deprecated ByteArrayInput|OutputStream references throughout project
> ---------------------------------------------------------------------------
>
> Key: NIFI-5376
> URL: https://issues.apache.org/jira/browse/NIFI-5376
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.7.0
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Priority: Major
> Labels: deprecated, warnings
>
> The Maven build produces numerous deprecation warnings because of references
> to deprecated custom versions of
> {{org.apache.nifi.stream.io.ByteArrayInputStream}} and
> {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced
> with
> {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}.
> {code}
> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
> nifi-utils ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 14 source files to
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,22]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,55]
> [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been
> deprecated
> [WARNING]
> /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[134,35]
> [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been
> deprecated
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
