[
https://issues.apache.org/jira/browse/NIFI-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505283#comment-16505283
]
ASF GitHub Bot commented on NIFI-5278:
--------------------------------------
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2768
@peter-toth Since this is adding a new dependency (at least directly and
possibly transitively) we'll at least need to make a License and Notice update.
Can you please verify what the old dependencies that would be included are for
impacted nar(s) and see what the difference is. The new artifacts need to be
in the Nar(s) L&N as appropriate. For commons-text at least I suspect we need
an entry in the spark-nar and possibly in the nifi-assembly notice as well.
Please take a look to identify the gaps so we can get this included.
To the other comment(s) from otto/marco it would be good, if there is
already a unit test, to create one which shows this change. If there were not
unit or integration tests I dont think you should be held to a higher standard
than the original author was while you're trying to fix a bug. We can proceed
without if so but we cannot proceed without L&N updates as needed.
> ExecuteSparkInteractive processor fails on code containing a quote
> ------------------------------------------------------------------
>
> Key: NIFI-5278
> URL: https://issues.apache.org/jira/browse/NIFI-5278
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Peter Toth
> Priority: Major
>
> ExecuteSparkInteractive uses
> org.apache.commons.lang.StringEscapeUtils.escapeJavaScript() which results
> quotes to be escaped as \'. This breaks JSON payload of the Livy REST API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
