[
https://issues.apache.org/jira/browse/NIFI-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504982#comment-16504982
]
ASF GitHub Bot commented on NIFI-5279:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2770
NIFI-5279: Allow components up to 50 milliseconds to complete validat…
…ion before returning from update request
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5279
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2770
----
commit bc7b48fe7ea6824a9a1008e3041a820d940df2ce
Author: Mark Payne <markap14@...>
Date: 2018-06-07T17:26:49Z
NIFI-5279: Allow components up to 50 milliseconds to complete validation
before returning from update request
----
> Wait a bit for components to finish validation on updates
> ---------------------------------------------------------
>
> Key: NIFI-5279
> URL: https://issues.apache.org/jira/browse/NIFI-5279
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.7.0
>
>
> When a Processor, Reporting Task, or Controller Service is updated, it is now
> validated asynchronously. This provides a faster response time for the web
> request but can sometimes result in a component showing a "Validating..."
> state when the response is received, even though the validation logic would
> complete very quickly. When we make an update to a component, instead of
> immediately creating the DTO, which would reflect that the state is
> "validating..." we should wait up to some amount of time (say 50
> milliseconds?) for the validation to complete, before we create the response.
> This way, components whose validation completes quickly still show as Valid
> or Invalid as soon as the response comes back and only those components that
> actually take a long time to validate will show as Validating.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
