[ 
https://issues.apache.org/jira/browse/NIFI-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502020#comment-16502020
 ] 

ASF GitHub Bot commented on NIFI-5266:
--------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2760#discussion_r193133584
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java
 ---
    @@ -261,7 +259,10 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
             OkHttpClient okHttpClient = getClient();
             final ComponentLog logger = getLogger();
     
    -        final String baseUrl = 
trimToEmpty(context.getProperty(ES_URL).evaluateAttributeExpressions().getValue());
    +        final String baseUrl = 
context.getProperty(ES_URL).evaluateAttributeExpressions().getValue().trim();
    +        if (StringUtils.isEmpty(baseUrl)) {
    --- End diff --
    
    Same as previous wrt baseUrl always being empty in the message


> PutElasticsearchHttp processors should sanitize parameters
> ----------------------------------------------------------
>
>                 Key: NIFI-5266
>                 URL: https://issues.apache.org/jira/browse/NIFI-5266
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> Currently PutElasticsearchHttp and PutElasticsearchHttpRecord put the 
> property values for index, type, and id into the Bulk API command as they are 
> specified in the processor properties. This can cause errors when special 
> characters such as a double-quote (") is encountered. Although a double-quote 
> (for example) is not supported in an index name, it is valid in a type name 
> and should be allowed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to