Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/347#discussion_r191843838
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -65,7 +65,13 @@ core::Property InvokeHTTP::FollowRedirects("Follow
Redirects", "Follow HTTP redi
core::Property InvokeHTTP::AttributesToSend("Attributes to Send", "Regular
expression that defines which attributes to send as HTTP"
" headers in the request. If
not defined, no attributes are sent as headers.",
"");
-core::Property InvokeHTTP::SSLContext("SSL Context Service", "The SSL
Context Service used to provide client certificate information for TLS/SSL
(https) connections.", "");
+core::Property InvokeHTTP::SSLContext("SSL Context Service",
+ "The SSL Context Service used to
provide client certificate "
+ "information for TLS/SSL (https)
connections.",
+ "",
+ false,
+ {},
+ {{"Remote URL", "^http:.*$"}});
--- End diff --
This is confusing because the PR is based on MINIFICPP-500
mutually-exclusive. This PR is for MINIFICPP-514 so that Remote URL
mutually-exclusive property is correct.
A URL regex could get complex, but in this case we're just checking for
HTTP protocol as per RFC3986 (which is exclusive of this SSL property, for
mutual-exclusivity as defined by MINIFICPP-467 E.g. "If I set certificates in
InvokeHTTP, I shouldnât allow http as the target protocol.").
Should it use a controller service? Probably. That's out of scope for this
ticket but I agree with a new ticket for that.
All these notes apply for MINIFICPP-500, not MINIFICPP-514.
---
