[GitHub] nifi-minifi-cpp pull request #315: MINIFICPP-472 Added date formatting EL fu...

[apiri]

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/315#discussion_r189289574
  
    --- Diff: thirdparty/date/test/clock_cast_test/custom_clock.pass.cpp ---
    @@ -0,0 +1,187 @@
    +// The MIT License (MIT)
    --- End diff --
    
    to minimize what we are carrying with our codebase, could we remove the 
test subdirectory from our thirdparty?


---