[GitHub] nifi pull request #2704: NIFI-4199: Consistent proxy support across componen...

[jvwing]

Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2704#discussion_r189164994
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java
 ---
    @@ -92,6 +94,23 @@
                 .addValidator(StandardValidators.PORT_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor PROXY_USERNAME = new 
PropertyDescriptor.Builder()
    +            .name("Proxy Username")
    +            .description("Proxy username")
    +            .expressionLanguageSupported(true)
    +            .required(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor PROXY_PASSWORD = new 
PropertyDescriptor.Builder()
    +            .name("Proxy Password")
    --- End diff --
    
    I recommend a separate `name` vs `displayName` for PROXY_PASSWORD.


---