[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

[pvillard31]

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2698#discussion_r188345339
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
    @@ -234,6 +247,11 @@ public void onStopped() {
     
         @OnScheduled
         public void onScheduled(final ProcessContext context) throws 
GrokException, IOException {
    +
    +        if (context.getProperty(KEEP_EMPTY_CAPTURES).isSet()) {
    --- End diff --
    
    with required=true, you would not need to check if the property is set 
anymore


---