[
https://issues.apache.org/jira/browse/NIFI-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407753#comment-16407753
]
ASF GitHub Bot commented on NIFI-4952:
--------------------------------------
GitHub user claudiu-stanciu opened a pull request:
https://github.com/apache/nifi/pull/2572
NIFI-4952 Add EL support for JettyWebSocketClient and JettyWebSocketS…
…erver properties
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/claudiu-stanciu/nifi
feature/NIFI-4952_Add_EL_JettyWebSocketClient
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2572
----
commit 4ba5936eaad84975b4d9fbe08c6444f10edfdc37
Author: claudiu stanciu <claudiu.a.stanciu@...>
Date: 2018-03-20T16:20:48Z
NIFI-4952 Add EL support for JettyWebSocketClient and JettyWebSocketServer
properties
----
> JettyWebSocketClient websocket-uri property missing
> evaluateAttributeExpressions
> --------------------------------------------------------------------------------
>
> Key: NIFI-4952
> URL: https://issues.apache.org/jira/browse/NIFI-4952
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Sven Van Hemel
> Priority: Major
>
> The {{websocket-uri property}} of the
> {{org.apache.nifi.websocket.jetty.JettyWebSocketClient}} class is marked as
> EL enabled, but its evaluation in the {{startClient()}} method seems to be
> missing a {{evaluateAttributeExpressions()}} call.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
