[
https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380042#comment-16380042
]
ASF GitHub Bot commented on MINIFICPP-411:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/269#discussion_r171185379
--- Diff: controller/MiNiFiController.cpp ---
@@ -178,7 +177,7 @@ int main(int argc, char **argv) {
auto& components = result["stop"].as<std::vector<std::string>>();
for (const auto& component : components) {
auto socket = secure_context != nullptr ?
stream_factory_->createSecureSocket(host, port, secure_context) :
stream_factory_->createSocket(host, port);
- if (!stopComponent(std::move(socket), component))
+ if (stopComponent(std::move(socket), component))
--- End diff --
The intent was to actually return false when writes failed. This is an
oversight. Thanks
> MiNIFi Controller's output needs some fixing
> --------------------------------------------
>
> Key: MINIFICPP-411
> URL: https://issues.apache.org/jira/browse/MINIFICPP-411
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: marco polo
> Assignee: marco polo
> Priority: Major
>
> A few operations need improved verification. Read me is not correct markup
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
