Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/269#discussion_r171160556
--- Diff: controller/MiNiFiController.cpp ---
@@ -178,7 +177,7 @@ int main(int argc, char **argv) {
auto& components = result["stop"].as<std::vector<std::string>>();
for (const auto& component : components) {
auto socket = secure_context != nullptr ?
stream_factory_->createSecureSocket(host, port, secure_context) :
stream_factory_->createSocket(host, port);
- if (!stopComponent(std::move(socket), component))
+ if (stopComponent(std::move(socket), component))
--- End diff --
I agree this is definitely the right intent, but it appears as though we
are not handling/propagating the returned value for writeData in
sendSingleCommand which always returns true.
---
