[
https://issues.apache.org/jira/browse/NIFI-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337864#comment-16337864
]
ASF GitHub Bot commented on NIFI-4367:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2201#discussion_r163567699
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/script/impl/ValidationContextAdapter.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.script.impl;
+
+import java.util.Map;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyValue;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.controller.ControllerService;
+import org.apache.nifi.controller.ControllerServiceLookup;
+import org.apache.nifi.expression.ExpressionLanguageCompiler;
+
+public abstract class ValidationContextAdapter implements
ValidationContext {
--- End diff --
I wonder if we should add a method here to retrieve the
innerValidationContext. It's not part of the ValidationContext interface of
course, but currently scripts that are expecting a StandardValidationContext
(and use methods on that class that are not on the interface) would break. If
we expose the underlying context, then the scripts could be updated by checking
to see if the context is a ValidationContextAdapter, then getting the
underlying context adapter if they want it. Thoughts?
> InvokedScriptedProcessor
> ------------------------
>
> Key: NIFI-4367
> URL: https://issues.apache.org/jira/browse/NIFI-4367
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.3.0, 1.4.0, 1.5.0
> Environment: Linux / Windows
> Reporter: Patrice Freydiere
> Priority: Major
> Labels: InvokeScriptedProcessor, validation
>
> InvokeScriptedProcessor pass his ValidationContext to the inner script,
> validate call
> InvokeScriptedProcessor Line 465 : final
> Collection<ValidationResult> instanceResults = instance.validate(context);
>
> The problem is that the invokedscript pass the ScriptFile PropertyDescriptor
> that is validated, if the script derived from the
> AbstractConfigurableComponent, (because the AbstractConfigurableComponent
> validate all the context properties).
> The context should be refined to remove the InvokeScriptedProcessor
> Properties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
