[ 
https://issues.apache.org/jira/browse/NIFI-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322436#comment-16322436
 ] 

ASF GitHub Bot commented on NIFI-4756:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2396

    NIFI-4756: Updated PublishKafkaRecord processors to include attribute…

    …s generated from schema write strategy into the message headers when 
appropriate
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-4756

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2396
    
----
commit 9bd9e6281560996688d2f9a328cadb484ab8c507
Author: Mark Payne <markap14@...>
Date:   2018-01-10T14:04:52Z

    NIFI-4756: Updated PublishKafkaRecord processors to include attributes 
generated from schema write strategy into the message headers when appropriate

----


> PublishKafkaRecord should consider schema-related attributes when publishing 
> records
> ------------------------------------------------------------------------------------
>
>                 Key: NIFI-4756
>                 URL: https://issues.apache.org/jira/browse/NIFI-4756
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.6.0
>
>
> Currently, if PublishKafkaRecord (0_10, 0_11, 1_0) is configured to write 
> flowfile attributes as headers, the attributes generated by the Schema Writer 
> are not taken into account. For example, if the Avro Record Writer is used 
> and configured with a Write Strategy of "Write 'schema.name' attribute" and 
> the Attributes to Send as Headers is set to "schema.*" then the schema.name 
> attribute is not sent. This is because the schema.name attribute does not 
> exist on the FlowFile yet but is generated by the Schema Writer



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to