[
https://issues.apache.org/jira/browse/NIFI-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320390#comment-16320390
]
ASF GitHub Bot commented on NIFI-4763:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2393
NIFI-4763: Ignore differences in components' Bundle Version when comp…
…aring a local flow to a flow in the registry
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4763
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2393
----
commit 895163799df09e6ceffbd0bbee4398e638969135
Author: Mark Payne <markap14@...>
Date: 2018-01-10T15:01:27Z
NIFI-4763: Ignore differences in components' Bundle Version when comparing
a local flow to a flow in the registry
----
> Versioned Flows show as dirty when component versions change
> ------------------------------------------------------------
>
> Key: NIFI-4763
> URL: https://issues.apache.org/jira/browse/NIFI-4763
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Bryan Bende
> Assignee: Mark Payne
> Priority: Minor
>
> While testing the 1.5.0 RC I happened to have an existing NiFi instance that
> was running the 1.5.0-SNAPSHOT version of the flow versioning PR, and had a
> bunch of example versioned flows. I upgraded this instance by replacing the
> lib directory with everything from the 1.5.0 RC.
> When I went to the UI I noticed all the versioned PGs were showing local
> changes. Looking at one of them it was because the local flow had upgraded
> all the component versions to 1.5.0, but the last version of that flow in the
> registry had the components at 1.5.0-SNAPSHOT.
> At this point you can try to rollback the local changes, but it can't really
> rollback because there are no more processors for 1.5.0-SNAPSHOT. You can
> save a new version of the flow with the new component versions and all is
> good.
> This won't really be an issue until the next release when folks have already
> been using 1.5.0 + registry for a while and upgrade to 1.6.0 (or whatever the
> next release is). We may want to ignore component version differences until
> sometime in the future when we have an extension registry.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
