[
https://issues.apache.org/jira/browse/NIFI-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280872#comment-16280872
]
ASF GitHub Bot commented on NIFI-4675:
--------------------------------------
GitHub user jasper-k opened a pull request:
https://github.com/apache/nifi/pull/2326
NIFI-4675 Lifted restriction on demarcator and kafka.key usage together
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
YES, NIFI-4675
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasper-k/apache-nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2326
----
commit 9ab024b8d36b64ac40b8eda6c3e46381d4a2c3cd
Author: jknulst <[email protected]>
Date: 2017-12-06T20:31:57Z
NIFI-4675 Lifted restriction on demarcator and kafka.key usage together
----
> PublishKafka_0_10 can't use demarcator and kafka key at the same time
> ---------------------------------------------------------------------
>
> Key: NIFI-4675
> URL: https://issues.apache.org/jira/browse/NIFI-4675
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Jasper Knulst
> Labels: performance
>
> At the moment you can't split up a flowfile using a demarcator AND set the
> Kafka key (kafka.key) attribute for all resulting Kafka records at the same
> time. The code explicitly prevents this.
> Still it would be a valuable performance booster to have the ability to use
> both at the same time in all cases where 1 flowfile contains many individual
> kafka records. Flowfiles would not have to be pre split (explosion of NiFi
> overhead) if you want to set the key.
> Note:
> Using demarcator and kafka key at the same time will normally make every
> resulting kafka record from 1 incoming flowfile to have the same kafka key
> (see REMARK).
> I know a live NiFi deployment where this fix/feature (provided as custom fix)
> led to a 500 - 600% increase in throughput. Others could and should benefit
> as well.
> REMARK
> The argument against this feature has been that it is not a good idea to
> intentionally generate many duplicate Kafka keys. I would argue that it is up
> to the user to decide. Most would use Kafka as a pure distributed log system
> and key uniqueness is not important. The kafka key can be really valuable
> grouping placeholder though. The only case where this would get problematic
> is on compaction of Kafka topics when kafka keys are deduplicated. But after
> we put sufficient warnings and disclaimers for this risk in the tooltips it
> is up to the user to decide whether to use the performance booster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
