[ 
https://issues.apache.org/jira/browse/NIFI-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261196#comment-16261196
 ] 

ASF GitHub Bot commented on NIFI-4597:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2266#discussion_r152358153
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenHTTP.java
 ---
    @@ -89,7 +90,7 @@ public void testPOSTRequestsReceivedReturnCodeWithoutEL() 
throws Exception {
             runner.setProperty(ListenHTTP.BASE_PATH, HTTP_BASE_PATH);
             runner.setProperty(ListenHTTP.RETURN_CODE, Integer.toString(204));
     
    -        testPOSTRequestsReceived(204);
    +        testPOSTRequestsReceived(HttpServletResponse.SC_OK);
    --- End diff --
    
    should this have been HttpServletResponse. SC_NO_CONTENT?  The line removed 
had a code of 204 but this is now passing in a 200.


> Add a property to override HTTP return code in ListenHTTP processor
> -------------------------------------------------------------------
>
>                 Key: NIFI-4597
>                 URL: https://issues.apache.org/jira/browse/NIFI-4597
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.4.0
>            Reporter: Sébastien Bouchex Bellomié
>             Fix For: 1.5.0
>
>
> Current ListenHTTP processor is always returning 200 as HTTP return code but 
> is some case, 204 may be required.
> I know that I may use the HandlerHttpRequest and HandlerHttpResponse couple 
> but that's a bit overkill to this.
> The idea is to have a property (default value is 200) giving the ability to 
> override the return code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to