[
https://issues.apache.org/jira/browse/NIFI-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255585#comment-16255585
]
ASF GitHub Bot commented on NIFI-4612:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2275
NIFI-4612: Allow AvroSchemaRegistry to disable name validation
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4612
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2275
----
commit c1c682870ffb3e72c551bc16f349d4bb0f5fa3be
Author: Matthew Burgess <[email protected]>
Date: 2017-11-16T16:49:02Z
NIFI-4612: Allow AvroSchemaRegistry to disable name validation
----
> Allow AvroSchemaRegistry to disable name validation
> ---------------------------------------------------
>
> Key: NIFI-4612
> URL: https://issues.apache.org/jira/browse/NIFI-4612
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
>
> The AvroSchemaRegistry is used to specify the schema/data format for Record
> Readers/Writers. The Readers/Writers are implemented for any data format
> (JSON, CSV, e.g.), which have their own rules for naming conventions and
> allowed characters, etc. However AvroSchemaRegistry imposes the Avro rules
> for naming, which can make it difficult/impossible to represent certain data
> formats as records, such as Mongo documents with operators as field names
> (such as $set).
> An improvement would be to add a boolean property to AvroSchemaRegistry
> (defaulted to true to retain current behavior) called "Validate Field Names".
> In the AvroSchemaValidator and AvroSchemaRegistry (both places where the
> schema is parsed), the value of Validate Field Names would be set on the
> parser using setValidate().
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
