[
https://issues.apache.org/jira/browse/NIFI-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251900#comment-16251900
]
ASF GitHub Bot commented on NIFI-4607:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2272
NIFI-4607, NIFI-3975, NIFI-4602, NIFI-4606: Fixed bug in TailFile tha…
…t caused new Primary Node to not pull current Clustered State when File
Location was set to Remote. Fixed bug that caused TailFile to occasionally
become 'stuck' when the file it is tailing is renamed and a new file is created
with the same name. Removed the 'Rolling Strategy' property from TailFile
because it is not actually used in the processor anymore. Deleted
MonitorMemoryTest because the unit test was testing the behavior of
FlowController more than the behavior of the reporting task itself and in order
to do so had a dependency in the pom.xml on nifi-framework-core, which means
that it no longer compiles when FlowController is modified.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4602
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2272.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2272
----
commit 1bc9a8c7a16804d9932e6a62f2a1837128be01b0
Author: Mark Payne <[email protected]>
Date: 2017-11-14T18:27:35Z
NIFI-4607, NIFI-3975, NIFI-4602, NIFI-4606: Fixed bug in TailFile that
caused new Primary Node to not pull current Clustered State when File Location
was set to Remote. Fixed bug that caused TailFile to occasionally become
'stuck' when the file it is tailing is renamed and a new file is created with
the same name. Removed the 'Rolling Strategy' property from TailFile because it
is not actually used in the processor anymore. Deleted MonitorMemoryTest
because the unit test was testing the behavior of FlowController more than the
behavior of the reporting task itself and in order to do so had a dependency in
the pom.xml on nifi-framework-core, which means that it no longer compiles when
FlowController is modified.
----
> MonitorMemory has problematic unit tests
> ----------------------------------------
>
> Key: NIFI-4607
> URL: https://issues.apache.org/jira/browse/NIFI-4607
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
>
> The MonitorMemoryTest class contains 3 unit tests. Two of them are ignored
> with @Ignore due to them depending on environmental condition. The third unit
> test depends on FlowController and is testing the framework as much as it is
> testing the Reporting Task itself.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
