[
https://issues.apache.org/jira/browse/NIFIREG-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251765#comment-16251765
]
ASF GitHub Bot commented on NIFIREG-45:
---------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi-registry/pull/37
NIFIREG-45 Refactor LoginIdentityProvider interface as a more generic…
… and flexible IdentityProvider interface
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi-registry NIFIREG-45
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-registry/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit d28144edbea5128b4265182dfb2a8e105a271d29
Author: Kevin Doran <[email protected]>
Date: 2017-10-30T18:39:56Z
NIFIREG-45 Refactor LoginIdentityProvider interface as a more generic and
flexible IdentityProvider interface
----
> Refactor NiFi Registry LoginIdentityProvider
> --------------------------------------------
>
> Key: NIFIREG-45
> URL: https://issues.apache.org/jira/browse/NIFIREG-45
> Project: NiFi Registry
> Issue Type: Improvement
> Reporter: Kevin Doran
> Assignee: Kevin Doran
>
> The initial implementation of identity provider implementation for NiFi
> Registry was based on the current (at the time) implementation on NiFi that
> used a LoginIdentityProvider Interface that authenticated a LoginCredentials
> object holding a username/password. This was for legacy reasons that were
> NiFi-specific relating to avoiding inclusion of servlet jars in the
> dependency for the identity provider api module.
> This is not a constraint for Registry (or NiFi any more apparently), so this
> ticket is to refactor this interface to be more general by authenticating a
> ServletRequest object, which would open implementations up to supporting more
> ways of the client passing in the identity claim (eg, cookie value).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
