Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/183#discussion_r150864184
  
    --- Diff: CMakeLists.txt ---
    @@ -155,6 +155,13 @@ if (ENABLE_USB_CAMERA)
         createExtension(USB-CAMERA-EXTENSIONS "USB CAMERA EXTENSIONS" "This 
enables USB camera support" "extensions/usb-camera" 
"${TEST_DIR}/usb-camera-tests" "TRUE" "thirdparty/libuvc-0.0.6")
     endif()
     
    +## TensorFlow extensions
    +## Disabled by default because TF can be complex/environment-specific to 
build
    +option(ENABLE_TENSORFLOW "Disables the TensorFlow extensions." OFF)
    +if (ENABLE_TENSORFLOW)
    +    createExtension(TENSORFLOW-EXTENSIONS "TENSORFLOW EXTENSIONS" "This 
enables TensorFlow support" "extensions/tensorflow" 
"${TEST_DIR}/tensorflow-tests")
    --- End diff --
    
    This extension should be compatible with that platform. The key thing would 
be building TF on (or for, with cross-compiling) the target.
    
    We are dynamically linking TF so it just has to be available in the target 
linking environment.
    
    As for build time, our custom FindTensorFlow.cmake needs to find the 
libtensorflow_cc.so and headers.
    
    Ultimately, it would be nice to have the ability to build TF in thirdparty/ 
and link statically, but there's currently no way to static link TF without 
giving up important features such as GPU acceleration.
    
    My thought was to keep it as an externally-provided and dynamically-linked 
library, and keep an eye on libtensorflow_cc as it matures and hopefully 
supports static linking options and cleaner embedded cmake files we could put 
in thirdparty/.


---

Reply via email to