[
https://issues.apache.org/jira/browse/NIFI-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251440#comment-16251440
]
ASF GitHub Bot commented on NIFI-4400:
--------------------------------------
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2269
@yuri1969 Thank you for this contribution! I must say, I very much enjoy
your coding style. During the review, though, I did notice a few things.
- The `^` characters for the version numbers in the package.json should be
removed.
- The fa-align-left icon on the 'Format' editor button does not appear to
be centered. It seems to be 1px too high.
- When a user hovers over the 'Save' button that the 'Changes saved
successfully' text seems to shift a few pixels.
- Documentation/code comments. Please add JS doc to all methods.
I would also like to see if @moranr or @mattyb149 have any other
suggestions for the styling of the components in this UI (for consistency with
nifi) or any other functionality we may want to add with this UI/UX.
I have a few other concerns with this advanced UI that I think we should
discuss here. At first @yuri1969 , I was wondering why you chose to use Angular
1.x. These advanced UI's are web applications in and of themselves so you could
have chosen any front end libraries you like. Then I realized that you probably
chose to use Angular v1.5.x because that is what Nifi (and the Jolt advance UI)
use and those libraries are already available in the nifi-web-ui. While I agree
that this is a practical approach (and follows what has already been
implemented previously in Nifi) I question whether this is a good long term
solution. We need a high quality and enforceable way to provide Nifi UI
developers with a set of reusable UI/UX components that can be leveraged in
nifi, any advanced nifi processor UI's, and the new nifi registry so that we
can deliver a consistent UX to our users across all our various 'web apps'.
There is a Jira out there (somewhere, although I cant find it right now) to
upgrade Angular to the latest and greatest and to move away from Angular 1.x.
There is also a lot of work being done right now for the upcoming nifi registry
release that will provide an NgModule called "Fluid Design System" that is
meant to be this "high quality reusable UI/UX component" module that will help
to provide a consistent UX. @mcgilman I would like your take on this as
well....I my mind I would really like to see this advanced UI be developed as
an Angular 4.x application and leverage the new FDS module.
Another concern I have is the lack of unit tests. This is not a knock
against @yuri1969 but rather a general statement on the state of the nifi UI
code base (and again @mcgilman I would like your input on this as I know I am
guilty of not providing unit tests for new nifi UI features as well). I feel
strongly that if we are going to introduce an entirely new web application (as
we are doing with the nifi registry and here with this advanced UI) that we
should hold it to the same quality standards we expect with any Java code
(including code formatting, code documentation, unit tests, and integration
tests). @yuri1969 whether or not we decide to use angular 1.x or 4.x It should
be fairly straight forward to include a karma.conf.js file and to leverage the
frontend-maven-plugin in the pom to run karma/jasmine tests for this advanced
UI.
@yuri1969 what do you think?
> Advanced UI with code editor for scripted processors
> ----------------------------------------------------
>
> Key: NIFI-4400
> URL: https://issues.apache.org/jira/browse/NIFI-4400
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI, Extensions
> Reporter: Pierre Villard
> Assignee: Yuri
>
> For the scripted processors it would nice to add an advanced UI with a "code
> editor mode" that would provide some very useful features when typing code:
> - indentation
> - code highlighting
> - do not close the window when hitting enter
> etc
> The use of codemirror.js (as already done for EL auto-completion) sounds like
> a good option.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
