Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145740328
  
    --- Diff: CMakeLists.txt ---
    @@ -101,6 +101,7 @@ set(CIVETWEB_ENABLE_SSL_DYNAMIC_LOADING OFF CACHE BOOL 
"Disable dynamic SSL libr
     set(CIVETWEB_ENABLE_CXX ON CACHE BOOL "Enable civet C++ library")
     add_subdirectory(thirdparty/yaml-cpp-yaml-cpp-0.5.3)
     add_subdirectory(thirdparty/civetweb-1.9.1 EXCLUDE_FROM_ALL)
    +add_subdirectory(thirdparty/libarchive-3.3.2)
    --- End diff --
    
    @calebj I think @achristianson point is valid that it shouldn't be done 
here. I will submit a PR to the other PR and then when that is merged ( should 
be the next day ), you will get that for free via the rebase. So feel free to 
ignore any comment about "extensions" since that is on me. thanks!


---

Reply via email to