[
https://issues.apache.org/jira/browse/NIFIREG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173738#comment-16173738
]
ASF GitHub Bot commented on NIFIREG-18:
---------------------------------------
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/10#discussion_r140073136
--- Diff:
nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/DataSourceFactory.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.registry.db;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.registry.properties.NiFiRegistryProperties;
+import org.h2.jdbcx.JdbcConnectionPool;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.context.annotation.Primary;
+
+import javax.sql.DataSource;
+import java.io.File;
+
+/**
+ * Overriding Spring Boot's normal automatic creation of a DataSource in
order to use the properties
+ * from NiFiRegistryProperties rather than the standard
application.properties/yaml.
+ */
+@Configuration
+public class DataSourceFactory {
+
+ private static final String DB_USERNAME_PASSWORD = "nifireg";
--- End diff --
This is the same approach taken in NiFi so I went with it, the thinking is
that the database can never be run in server mode and exposed outside of the
file on the server, so at that point you are down to file permissions.
> Refactor MetadataProvider to use an embedded database
> -----------------------------------------------------
>
> Key: NIFIREG-18
> URL: https://issues.apache.org/jira/browse/NIFIREG-18
> Project: NiFi Registry
> Issue Type: Improvement
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
>
> We need to leverage transactions when persisting data to avoid inconsistent
> states. Currently the MetadataProvider is based on an XML file which doesn't
> offer much way to rollback an operation. We should switch to using an
> embedded database.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
