Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/2140
  
    Thanks for the update, @christophercurrie .  This PR is looking pretty good:
    * Passes the full suite of unit tests with contrib-check.
    * AWS processors and controller service still work OK in my testing.
    * Provides a good migration experience -- just rebuild against NiFi 1.4.0 
nars -- better than I feared.  More below.
    
    One thing we still need is a set of LICENSE/NOTICE files for 
nifi-aws-service-api-nar, similar to what is now in the nifi-aws-nar.  I 
believe the NOTICE file can be pared down to only reference the aws-sdk.
    
    **Migration Experience**
    I created a [simple AWS 
bundle](https://github.com/jvwing/sample-aws-bundle) targeting NiFi 1.3.0, and 
went through the exercise of [migrating 
it](https://github.com/jvwing/sample-aws-bundle/tree/target-nifi-1.4.0) to 
1.4.0 as of this PR.  It seems "smooth" enough to me.
    * Advancing the NiFi dependency version to 1.4.0 and rebuilding is enough, 
maintaining the NAR dependency on `nifi-aws-nar`.
    * For bundles that only implement controller service interfaces, they may 
optionally change their NAR dependency to `nifi-aws-service-api-nar`.  Since 
nifi-aws-nar already has this NAR dependency, I believe this is a recommended, 
but not strictly necessary step.


---

Reply via email to