Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2055
Hi @pvillard31 , thanks for tackling this! Although the proposed change can
keep a signal when there are counts remaining, I found that:
- Current implementation of Wait and WaitNotifyProtocal are already
complex, and adding another execution branch would make it more complex, and
hard to maintain
- Calling WaitNotifyProtocol.notify method from Wait is not expected by
design.
So, I'd like to propose different approach, that refactors and consolidates
current implementation so that Wait processor has less different execution
paths in its code. That would be more understandable for developers and users.
Would you take a look at this commit? This branch has 1 more commit based on
this PR:
https://github.com/ijokarumawak/nifi/commit/9bc38bb7ef62a11e0a137b7992eba93b75374453
If it looks reasonable, please add it to your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
