[
https://issues.apache.org/jira/browse/NIFI-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113471#comment-16113471
]
ASF GitHub Bot commented on NIFI-4028:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2055
NIFI-4028 - fix cache update when Wait releases flow files
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-4028
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2055.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2055
----
commit 5adcb0b2db68eef18fb7bcc84634436d36c97be7
Author: Pierre Villard <[email protected]>
Date: 2017-08-03T20:56:27Z
NIFI-4028 - fix cache update when Wait releases flow files
----
> Wait processor removes cache regardless of the remaing counter
> --------------------------------------------------------------
>
> Key: NIFI-4028
> URL: https://issues.apache.org/jira/browse/NIFI-4028
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Pierre Villard
> Attachments: WaitNotify_NIFI-4028.xml
>
>
> Current [Wait processor implementation removes cache
> entry|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/Wait.java#L438]
> if it's configured with 'Releasable FlowFile Count' is one, when it finds a
> wait signal reaches to 'Target Signal Count' no matter how large the current
> count is.
> This behavior can be problematic, when an user expects the same Signal
> Identifier to be released multiple FlowFiles one by one while multiple counts
> to be accumulated by Notify.
> For example this scenario does not work:
> {code}
> 1. Notify notifies to a 'signal-a' + 1 => 'signal-a' = 1
> 2. Notify notifies to a 'signal-a' again, +1 => 'signal-a' = 2
> 3. Wait releases 1 FlowFile, then remove the 'signal-a' => 'signal-a' is
> removed
> 4. Wait will not be able to release another FlowFile
> {code}
> This should be fixed as follows:
> {code}
> 1. Notify notifies to a 'signal-a' + 1 => 'signal-a' = 1
> 2. Notify notifies to a 'signal-a' again, +1 => 'signal-a' = 2
> 3. Wait releases 1 FlowFile, then update the 'signal-a', -1 => 'signal-a' = 1
> 4. Wait releases another FlowFile, then 'signal-a' becomes 0, remove
> 'signal-a'
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
