[
https://issues.apache.org/jira/browse/NIFI-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100685#comment-16100685
]
ASF GitHub Bot commented on NIFI-3335:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2039
NIFI-3335: Add initial.maxvalue support to GenerateTableFetch
Moved the common code back to the abstract base class
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2039
----
commit 8eea477c02fdb2ca19ec77da9168ceec5e8eae7c
Author: Matt Burgess <[email protected]>
Date: 2017-07-25T20:07:52Z
NIFI-3335: Add initial.maxvalue support to GenerateTableFetch
----
> GenerateTableFetch should allow you to specify an initial Max Value
> -------------------------------------------------------------------
>
> Key: NIFI-3335
> URL: https://issues.apache.org/jira/browse/NIFI-3335
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
>
> NIFI-2583 added the ability (via dynamic properties) to specify initial Max
> Values for columns, to enable the user to "pick up where they left off" if
> something happened with a flow, a NiFi instance, etc. where the state was
> stored but the processing did not complete successfully.
> This feature would also be helpful in GenerateTableFetch, which also supports
> max-value columns.
> Since NIFI-2881 adds incoming flow file support, it's more useful if Initial
> max values can be specified via flow file attributes. Because if a table name
> is dynamically passed via flow file attribute and Expression Language, user
> won't be able to configure dynamic processor attribute in advance for each
> possible table.
> Add dynamic properties ('initial.maxvalue.<max_value_column>' same as
> QueryDatabaseTable) to specify initial max values statically, and also use
> incoming flow file attributes named 'initial.maxvalue.<max_value_column>' if
> any.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
