Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123644079
--- Diff: libminifi/include/provenance/Provenance.h ---
@@ -160,21 +161,9 @@ class ProvenanceEventRecord : protected
org::apache::nifi::minifi::io::Serializa
/*!
* Create a new provenance event record
*/
- ProvenanceEventRecord(ProvenanceEventType event, std::string
componentId, std::string componentType)
- :
logger_(logging::LoggerFactory<ProvenanceEventRecord>::getLogger()) {
- _eventType = event;
- _componentId = componentId;
- _componentType = componentType;
- _eventTime = getTimeMillis();
- char eventIdStr[37];
- // Generate the global UUID for th event
- uuid_generate(_eventId);
- uuid_unparse_lower(_eventId, eventIdStr);
- _eventIdStr = eventIdStr;
- }
+ ProvenanceEventRecord(ProvenanceEventType event, std::string
componentId, std::string componentType);
--- End diff --
Thanks. I'm guilty of doing this too and it's so much cleaner to move it
out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
