[
https://issues.apache.org/jira/browse/NIFI-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059956#comment-16059956
]
ASF GitHub Bot commented on NIFI-4110:
--------------------------------------
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1935
NIFI-4110 Added Thread.sleep() to ensure provenance event indexing oc…
…curs before retrieval and unit test passes.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-4110
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1935.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1935
----
commit cce2bf0a10cbd6f6f65515bbfe832e0172f234e9
Author: Andy LoPresto <[email protected]>
Date: 2017-06-22T20:19:06Z
NIFI-4110 Added Thread.sleep() to ensure provenance event indexing occurs
before retrieval and unit test passes.
----
> Encrypted provenance repository test can fail due to timing
> -----------------------------------------------------------
>
> Key: NIFI-4110
> URL: https://issues.apache.org/jira/browse/NIFI-4110
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.3.0
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Labels: provenance, test, timing
>
> There is an occasional failure in the unit tests for the
> {{EncryptedWriteAheadProvenanceRepository}} where the events retrieved (9)
> are less than the expected number (10) because it has not yet indexed the
> last event. Adding a {{Thread.sleep(1000)}} seems to resolve this
> consistently.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.nifi.provenance.EncryptedSchemaRecordReaderWriterTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.473 sec -
> in org.apache.nifi.provenance.EncryptedSchemaRecordReaderWriterTest
> Running org.apache.nifi.provenance.EncryptedWriteAheadProvenanceRepositoryTest
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec <<<
> FAILURE! - in
> org.apache.nifi.provenance.EncryptedWriteAheadProvenanceRepositoryTest
> testWriteAheadProvenanceRepositoryShouldRegisterAndRetrieveEvents(org.apache.nifi.provenance.EncryptedWriteAheadProvenanceRepositoryTest)
> Time elapsed: 0.033 sec <<< FAILURE!
> org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert
> recoveredRecords.size() == RECORD_COUNT
> | | | |
> | 9 | 10
> | false
> [ProvenanceEventRecord [eventId=0, eventType=RECEIVE, eventTime=Thu
> Jun 22 11:09:07 EDT 2017, uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f,
> fileSize=0, componentId=1234, transitUri=nifi://unit-test,
> sourceSystemFlowFileIdentifier=null, parentUuids=[],
> alternateIdentifierUri=null], ProvenanceEventRecord [eventId=1,
> eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null], ProvenanceEventRecord
> [eventId=2, eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null], ProvenanceEventRecord
> [eventId=3, eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null], ProvenanceEventRecord
> [eventId=4, eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null], ProvenanceEventRecord
> [eventId=5, eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null], ProvenanceEventRecord
> [eventId=6, eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null], ProvenanceEventRecord
> [eventId=7, eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null], ProvenanceEventRecord
> [eventId=9, eventType=RECEIVE, eventTime=Thu Jun 22 11:09:07 EDT 2017,
> uuid=2c2f9e5e-ebda-4ac1-a954-4b1d0d9ddd1f, fileSize=0, componentId=1234,
> transitUri=nifi://unit-test, sourceSystemFlowFileIdentifier=null,
> parentUuids=[], alternateIdentifierUri=null]]
> at
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402)
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650)
> at
> org.apache.nifi.provenance.EncryptedWriteAheadProvenanceRepositoryTest.testWriteAheadProvenanceRepositoryShouldRegisterAndRetrieveEvents(EncryptedWriteAheadProvenanceRepositoryTest.groovy:237)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
