[
https://issues.apache.org/jira/browse/NIFI-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990786#comment-15990786
]
ASF GitHub Bot commented on NIFI-3651:
--------------------------------------
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1721
NIFI-3651 - Add logo to README.md
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] ~~~Have you written or updated unit tests to verify your changes?~~~
- [X] ~~~If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?~~~
- [X] ~~~If applicable, have you updated the LICENSE file, including the
main LICENSE file under nifi-assembly?~~~
- [X] ~~~If applicable, have you updated the NOTICE file, including the
main NOTICE file found under nifi-assembly?~~~
- [X] ~~~If adding new Properties, have you added .displayName in addition
to .name (programmatic access) for each of the new properties?~~~
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-3651
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1721.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1721
----
commit 9c0a99f1e6fbe13c8eb9c442f16d34eb8ca4b8b1
Author: Andre F de Miranda <[email protected]>
Date: 2017-05-01T12:56:52Z
NIFI-3651 - Add logo to README.md
----
> Consider adding logo to README.md
> ---------------------------------
>
> Key: NIFI-3651
> URL: https://issues.apache.org/jira/browse/NIFI-3651
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website
> Reporter: Keith Turner
> Assignee: Andre F de Miranda
>
> I recently made a PR to make the projects README.md link to the website first
> thing. In my opinion it would be nicer to make the README use the project
> logo and have that logo link to the website. We did this for Fluo and I
> think it's nice.
> https://github.com/apache/incubator-fluo
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
