bobpaulin commented on code in PR #11872:
URL: https://github.com/apache/nifi/pull/11872#discussion_r4645447051
##########
nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication/ClusteredConnectorRequestReplicator.java:
##########
@@ -41,30 +49,69 @@ public class ClusteredConnectorRequestReplicator implements
ConnectorRequestRepl
private static final String GET = "GET";
private final Supplier<RequestReplicator> requestReplicatorSupplier;
+ private final Supplier<ClusterCoordinator> clusterCoordinatorSupplier;
private final String replicationScheme;
- public ClusteredConnectorRequestReplicator(final
Supplier<RequestReplicator> requestReplicatorSupplier, final boolean
httpsEnabled) {
+ public ClusteredConnectorRequestReplicator(final
Supplier<RequestReplicator> requestReplicatorSupplier, final
Supplier<ClusterCoordinator> clusterCoordinatorSupplier,
+ final boolean httpsEnabled) {
this.requestReplicatorSupplier =
Objects.requireNonNull(requestReplicatorSupplier, "Request Replicator Supplier
required");
+ this.clusterCoordinatorSupplier =
Objects.requireNonNull(clusterCoordinatorSupplier, "Cluster Coordinator
Supplier required");
this.replicationScheme = httpsEnabled ? "https" : "http";
}
@Override
public ConnectorState getState(final String connectorId) throws
IOException {
+ final ConnectorEntity connectorEntity =
getConnectorEntity(connectorId, false);
Review Comment:
[Claude Opus 5.5] Agreed, that's a real hang. The membership wait only
exists for an evolution that resumes during startup, and that path already
settles membership in the drain barrier: getFlowEvolutionStatus waits for
joining nodes and fails on any node that isn't connected, and runFlowEvolution
always passes it before completeUpdate. So getState doesn't need the check on
either path. I've restored its previous behavior: it replicates to the
connected nodes, and waitForState no longer retries when the cluster is
unavailable, so an ordinary update fails to UPDATE_FAILED as before instead of
waiting in PREPARING_FOR_UPDATE. The strict membership check now applies only
to the flow evolution barrier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]