exceptionfactory commented on code in PR #11958:
URL: https://github.com/apache/nifi/pull/11958#discussion_r4643901471


##########
nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/impl/SocketProtocolListener.java:
##########
@@ -133,7 +133,8 @@ public void dispatchRequest(final Socket socket) {
         String hostname = null;
         try {
             final StopWatch stopWatch = new StopWatch(true);
-            hostname = socket.getInetAddress().getHostName();
+            // Avoid getHostName(): it performs a reverse DNS lookup that can 
block for the resolver timeout before the request is read

Review Comment:
   This comment can be removed since it reflects the previous implementation 
and the new utility method documents the preferred behavior



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to