anshuksi282-ksolves opened a new pull request, #11941:
URL: https://github.com/apache/nifi/pull/11941

   ## Summary
   
   [NIFI-16603](https://issues.apache.org/jira/browse/NIFI-16603) 
   Fixes the inverted check on the return value of 
`ProcessHandle.destroyForcibly()` in `StopBootstrapCommand`.
   
   When the application process did not stop within the graceful shutdown 
timeout and `destroyForcibly()` returned `true`, the command logged `force 
termination failed` and did not wait for the process to exit, so the command 
status remained `ERROR`. The command now waits for the process to exit and sets 
`SUCCESS` when the forced termination request is accepted, matching the 
handling of `destroy()`.
   
   A new test in `StopBootstrapCommandTest` covers a successful forced 
termination after the graceful shutdown timeout.
   
   ## Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-00000`
   - [x] Pull request contains [commits 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   ## Verification
   
   ### Build
   
   - [x] Build completed using `./mvnw clean install -P contrib-check`
     - [x] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the Apache License 2.0
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to